Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init-distro-rid.sh and init-os-arch.sh to eng/common/native #13947

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

elinor-fung
Copy link
Member

These are copied from:
https://github.com/dotnet/runtime/blob/main/eng/native/init-distro-rid.sh
https://github.com/dotnet/runtime/blob/main/eng/native/init-os-and-arch.sh

cc @am11 @jander-msft who did the last syncs to diagnostics and dotnet-monitor

Fixes: #13946

To double check:

@elinor-fung elinor-fung requested a review from missymessa August 7, 2023 23:06
missymessa
missymessa previously approved these changes Aug 7, 2023
Copy link
Member

@missymessa missymessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM shipit

Copy link
Member

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be nice to lower the dependency (no bash) for this as well similar to init-compiler.sh -- at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arcade should include scripts for determining OS name, architecture, and distro RID
3 participants