-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[.NET 9] Remove UsingToolMicrosoftNetILLinkTasks switch #14021
Conversation
@mmitche when should we expect Arcade to branch-off so that we can get this change merged? |
I don't think we talked about this, but I could work on this |
Maybe that was someone else. @tkapin did I talk to you about this? |
@mmitche - I don't this so, this doesn't ring a bell. |
@sbomer can you please review? This was a feature that only dotnet/runtime used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! We should probably hold off on merging it until dotnet/runtime#91468 is ready.
Blocked by dotnet/runtime#91468
This shouldn't be merged into main as long as Arcade targets .NET 8.
Runtime was the only consumer of that switch and we now use the live built asset instead. Also, the linker is now in-built into the .NET SDK and doesn't need to be referenced explicitly anymore.
To double check: