Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NET 9] Remove UsingToolMicrosoftNetILLinkTasks switch #14021

Merged
merged 7 commits into from
Oct 6, 2023

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Sep 11, 2023

Blocked by dotnet/runtime#91468

This shouldn't be merged into main as long as Arcade targets .NET 8.

Runtime was the only consumer of that switch and we now use the live built asset instead. Also, the linker is now in-built into the .NET SDK and doesn't need to be referenced explicitly anymore.

To double check:

@ViktorHofer
Copy link
Member Author

@mmitche when should we expect Arcade to branch-off so that we can get this change merged?

@mmitche
Copy link
Member

mmitche commented Sep 11, 2023

@mmitche when should we expect Arcade to branch-off so that we can get this change merged?

I may be recalling incorrectly, but I think @dkurepa was going to work on this sometime soon?

@dkurepa
Copy link
Member

dkurepa commented Sep 13, 2023

I don't think we talked about this, but I could work on this

@mmitche
Copy link
Member

mmitche commented Sep 13, 2023

I don't think we talked about this, but I could work on this

Maybe that was someone else. @tkapin did I talk to you about this?

@tkapin
Copy link
Member

tkapin commented Sep 13, 2023

@mmitche - I don't this so, this doesn't ring a bell.

@ViktorHofer
Copy link
Member Author

@sbomer can you please review? This was a feature that only dotnet/runtime used.

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! We should probably hold off on merging it until dotnet/runtime#91468 is ready.

@ViktorHofer ViktorHofer merged commit 6358d55 into main Oct 6, 2023
11 checks passed
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-4 branch October 6, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants