Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make post-build.yml accept parameters to sdk-task.ps1 #3676

Merged
merged 20 commits into from
Aug 14, 2019
Merged

Make post-build.yml accept parameters to sdk-task.ps1 #3676

merged 20 commits into from
Aug 14, 2019

Conversation

JohnTortugo
Copy link
Contributor

@JohnTortugo JohnTortugo commented Aug 14, 2019 •
edited
Loading

Closes: #3666 #3661
Tests: 310059 310150

Add new parameters to post-build.yml that can be used to:

  • Pass parameters to sdk-tasks.ps1 which let users to customize the invocation of sdk-tasks.
  • Set default values for DotNetArtifactsCategory and DotNetValidationArtifactsCategory

@JohnTortugo JohnTortugo requested a review from riarenas August 14, 2019 19:23
@JohnTortugo JohnTortugo self-assigned this Aug 14, 2019
riarenas
riarenas reviewed Aug 14, 2019
View reviewed changes
azure-pipelines.yml Outdated Show resolved Hide resolved
riarenas
riarenas requested changes Aug 14, 2019
View reviewed changes
Copy link
Member

@riarenas riarenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke offline. We need to still respect the value of the variable for repos that have already onboarded. They shouldn't need to specify the parameter for the right thing to happen.

@JohnTortugo JohnTortugo merged commit 42aa262 into master Aug 14, 2019
@JohnTortugo JohnTortugo deleted the NewPostBuildParams branch August 14, 2019 22:58
@dagood dagood mentioned this pull request Aug 15, 2019
Merged
@dagood dagood mentioned this pull request Aug 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riarenas riarenas riarenas approved these changes

Assignees

@JohnTortugo JohnTortugo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[post-build] Allow passing additional parameters to sdk-task.ps1 invocation in the post-build yaml template
2 participants
@JohnTortugo @riarenas