Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SignCheck fixes #4058

Merged
merged 3 commits into from
Oct 8, 2019
Merged

SignCheck fixes #4058

merged 3 commits into from
Oct 8, 2019

Conversation

joeloff
Copy link
Member

@joeloff joeloff commented Oct 4, 2019

  1. Fixes Using SignCheck to verify that a file is not signed #3749 - exclusions can now include a special comment "DO-NOT-SIGN" to report signed files that should not be signed as errors
  2. Better handling for file patterns/parents in exclusions
  3. Special case handling for archive files (nupkg, zip) that include MSIs with external CAB files to ensure that the files are all extracted first as files cannot be extracted from the MSI if the external CAB isn't available.
  4. Includes a check to verify repository signatures in NuGet packages. This is a new feature in NuGet where any package published to nuget.org is automatically signed with a repository certificate.

@joeloff joeloff requested a review from dagood October 4, 2019 06:37
@markwilkie
Copy link
Member

Thanks @joeloff !

@JohnTortugo is probably interested as well.

dagood
dagood approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@dagood dagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 😄

@joeloff joeloff merged commit 7a976ab into master Oct 8, 2019
joeloff added a commit that referenced this pull request Oct 9, 2019
@joeloff
SignCheck fixes (#4058)
c4e1d8b 
* Add support for files that should never be signed
* nupkg repository signature checks
* Fix handling external CAB files in containers to ensure both the CAB + MSI are extracted before verifying the MSI
mmitche pushed a commit that referenced this pull request Oct 9, 2019
@joeloff @mmitche
SignCheck fixes (#4058) (#4083)
f9aa63e 
* Add support for files that should never be signed
* nupkg repository signature checks
* Fix handling external CAB files in containers to ensure both the CAB + MSI are extracted before verifying the MSI
@riarenas riarenas deleted the joeloff/do-not-sign branch January 28, 2020 19:19
This was referenced Aug 21, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagood dagood dagood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using SignCheck to verify that a file is not signed
3 participants
@joeloff @markwilkie @dagood