Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging of service process details on timeout #4253

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Add logging of service process details on timeout #4253

merged 1 commit into from
Oct 31, 2019

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Oct 31, 2019

@jkotas jkotas requested a review from stephentoub October 31, 2019 03:52
ViktorHofer
ViktorHofer approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if tasklist.exe is available on Nano but I don't think we care.

@jkotas jkotas merged commit 3bbaf86 into master Oct 31, 2019
@stephentoub stephentoub deleted the more-logging branch October 31, 2019 16:44
@MattGal
Copy link
Member

MattGal commented Oct 31, 2019

I just checked; Tasklist.exe is indeed unavailable in Nano but since it's in a try catch doesn't matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@stephentoub stephentoub Awaiting requested review from stephentoub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkotas @MattGal @ViktorHofer