Remove copy instructions in PushToAzureDevOpsArtifacts

[JohnTortugo]

Closes: #4564

This is the first of two PRs. Second one will be to remove the copy instructions in the SDK Publish.proj.

This change and also the one in the SDK have been tested here: https://dnceng.visualstudio.com/internal/_build/results?buildId=465204&view=results https://dnceng.visualstudio.com/internal/_build/results?buildId=465001&view=results

[riarenas]

Happy that we don't need this anymore.

[riarenas]

Hmm, on second thought I wonder if we should wait a bit before pushing this to repos, We made sure that Arcade doesn't move the artifacts around anymore, but if someone else does it as well, this would end up breaking official builds without any warning in the PR.

[mmitche]

Hmm, on second thought I wonder if we should wait a bit before pushing this to repos, We made sure that Arcade doesn't move the artifacts around anymore, but if someone else does it as well, this would end up breaking official builds without any warning in the PR.

@JohnTortugo Is there any way to roll out an update that would flag this initially if repos are doing something bad?

[JohnTortugo]

Hmm, on second thought I wonder if we should wait a bit before pushing this to repos, We made sure that Arcade doesn't move the artifacts around anymore, but if someone else does it as well, this would end up breaking official builds without any warning in the PR.

@JohnTortugo Is there any way to roll out an update that would flag this initially if repos are doing something bad?

I think unfortunately there isn't much we can do. The potential issue here is for files be moved/deleted after we emit the ##vso command but before AzDO actually execute the upload. So, I think a better error message in the ##vso implementation would be the right thing.

That being said, I added some File.Exists conditions in the task. That will at least tell us that the file existed at the right place at some point in time (or not).

What do you think?

[riarenas]

@JohnTortugo Is there any way to roll out an update that would flag this initially if repos are doing something bad?

Maybe we can make this in two stages:

1. Log something if we see that assetsTemporaryDirectory is being passed to the task. Look for those logs in repos that have a publishing.props file somewhere (Which I think would be the only place to actually customize this behavior)
2. Second change that actually removes the property from the task after letting people know.

Or maybe we can simply remove the usage of the property from Arcade and keep it in the task?

[JohnTortugo]

Talked offline. I'll remove the usage of the property in the task & SDK and change the task to print a message saying that the property is deprecated if it's used.