Fix a build break when using new GenApi #5269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- example failure in https://dev.azure.com/dnceng/internal/_build/results?buildId=601199 - undo a small part of #4585) - restore generation of `[StructLayout]` attributes on most value types - original commit was 1faec9a
dougbu
requested review from
ericstj,
jaredpar,
markwilkie,
mmitche,
missymessa and
Anipik
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hey @mmitche please stop cancelling the validation builds. That just moves the jobs to the end of the queue. My earlier attempts at this were wrong-headed. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
I don't think those were going to start. They got caught by the provisioning failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[StructLayout]attributes on most value types