Set XUnitVSRunnerVersion to 2.4.3 #6020
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpatalas
commented
Aug 24, 2020
| @@ -86,7 +86,7 @@ | |||
| <MicrosoftTestPlatformVersion Condition="'$(MicrosoftTestPlatformVersion)' == ''">16.5.0</MicrosoftTestPlatformVersion> | |||
| <XUnitVersion Condition="'$(XUnitVersion)' == ''">2.4.1</XUnitVersion> | |||
| <XUnitRunnerConsoleVersion Condition="'$(XUnitRunnerConsoleVersion)' == ''">$(XUnitVersion)</XUnitRunnerConsoleVersion> | |||
| <XUnitRunnerVisualStudioVersion Condition="'$(XUnitRunnerVisualStudioVersion)' == ''">$(XUnitVersion)</XUnitRunnerVisualStudioVersion> | |||
| <XUnitRunnerVisualStudioVersion Condition="'$(XUnitRunnerVisualStudioVersion)' == ''">$(XUnitVSRunnerVersion)</XUnitRunnerVisualStudioVersion> | |||
There was a problem hiding this comment.
@riarenas @missymessa I'm not sure if this change is enough. Should we also hardcode XUnitRunnerVisualStudioVersion in case XUnitVSRunnerVersion is unset? Previously it was not a problem because runner version was the same as xunit itself but now they differ.
|
@premun Yes, good catch. I'm closing it because it's just a duplicate of that other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #6019 -
xunit.runner.visualstudio2.4.1 does not work with .NET 5 Preview 8. This PR upgrades it to 2.4.3.