Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .NET 6.0 version of XHarness #7151

Merged
merged 4 commits into from
Mar 26, 2021
Merged

Use .NET 6.0 version of XHarness #7151

merged 4 commits into from
Mar 26, 2021

Conversation

premun
Copy link
Member

@premun premun commented Mar 25, 2021

MattGal
MattGal approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of wonder if the duplicated value defaults should be promoted to props in a shared file

@premun
Copy link
Member Author

premun commented Mar 25, 2021

@MattGal yeah, originally it was a workaround that should be dealt with in #7022

@premun premun merged commit 623a95c into dotnet:main Mar 26, 2021
@premun premun deleted the prvysoky/xharness-net6.0 branch March 26, 2021 12:17
akoeplinger pushed a commit to akoeplinger/arcade that referenced this pull request Apr 12, 2021
@premun @akoeplinger
Use .NET 6.0 version of XHarness (dotnet#7151)
aacb3ef 
* Bump XHarness
* Use .NET 6 preview 2 in XHarness workloads
* Target net6.0 when installing the tool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattGal MattGal MattGal approved these changes

@greenEkatherine greenEkatherine Awaiting requested review from greenEkatherine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@premun @MattGal