Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LangIDOnPath templates to LocProject.json generation #7187

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

jonfortescue
Copy link
Contributor

Closes dotnet/core-eng#12673.

Some repos (like winforms) use templates that have langcodes as directories (e.g. en\strings.json, fr\string.json). This PR adds support for that.

To double check:

Copy link
Member

@ChadNedzlek ChadNedzlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we don't control the "LandIDOnName" value, right? That 'D', REALLY needs to be lowercased. It took me like a solid minute of brain melting before I figured out what it was saying. :-)

@jonfortescue
Copy link
Contributor Author

@ChadNedzlek forgot to reply to this but indeed we do not haha.

Going to wait until I'm off FR to merge this so I can babysit it as it rolls out.

@jonfortescue jonfortescue merged commit 1d95129 into dotnet:main Apr 19, 2021
@jonfortescue jonfortescue deleted the TemplateOutputPath branch April 19, 2021 21:53
jonfortescue added a commit to jonfortescue/arcade that referenced this pull request Apr 22, 2021
jonfortescue added a commit to jonfortescue/arcade that referenced this pull request Apr 22, 2021
jonfortescue added a commit to jonfortescue/arcade that referenced this pull request Apr 22, 2021
jonfortescue added a commit to jonfortescue/arcade that referenced this pull request Apr 22, 2021
jonfortescue added a commit to jonfortescue/arcade that referenced this pull request Apr 22, 2021
jonfortescue added a commit to jonfortescue/arcade that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants