Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable passing custom properties to NativeProjectReference items with AdditionalProperties metadata #7237

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

jkoritzinsky
Copy link
Member

Pass down AdditionalProperties for NativeProjectReferences. Precalculate if the generator is multi-config so the CopyNativeProjectBinaries target doesn't need to call into the CMake project.

WinForms team validated these changes.

cc: @RussKie

To double check:

…ate if the generator is multi-config so the CopyNativeProjectBinaries target doesn't need to call into the CMake project
@jkoritzinsky jkoritzinsky requested a review from RussKie April 14, 2021 16:35
@RussKie
Copy link
Member

RussKie commented Apr 14, 2021

Thank you @jkoritzinsky!

@jkoritzinsky
Copy link
Member Author

Failure is in xharness for Android, which is unrelated to this code. Rerunning the leg to try to get a green build.

@jkoritzinsky jkoritzinsky merged commit 4fdee21 into dotnet:main Apr 15, 2021
@jkoritzinsky jkoritzinsky deleted the cmake-specify-architecture branch April 15, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants