Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run signcheck in single threaded apartment #7241

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

chcosta
Copy link
Member

@chcosta chcosta commented Apr 14, 2021

Fixes #7238

Remove WTD_SAFER_FLAG which is no longer supported - see https://docs.microsoft.com/en-us/windows/win32/api/wintrust/ns-wintrust-wintrust_data

Load task in separate app domain

Use Single Threaded Apartment

Copy link
Contributor

@michellemcdaniel michellemcdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

@chcosta chcosta merged commit 40ecdb3 into dotnet:main Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignCheck failing to validated javascript files are signed
4 participants