Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK to preview 3 #7254

Merged
merged 4 commits into from
Apr 22, 2021
Merged

Update SDK to preview 3 #7254

merged 4 commits into from
Apr 22, 2021

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Apr 15, 2021

To double check:

@mmitche mmitche requested review from ViktorHofer and riarenas April 15, 2021 17:20
@mmitche
Copy link
Member Author

mmitche commented Apr 21, 2021

@alexperovich It looks like whatever is processing the binlog needs to support a newer version. Can you take a look?

@ViktorHofer
Copy link
Member

@MattGal that should be the corresponding issue: #7024.

@alexperovich
Copy link
Member

I think this was hit by runtime a while ago, #7274 should fix this.

@ViktorHofer
Copy link
Member

@alexperovich did you see #7024 which I filed some months ago?

@alexperovich
Copy link
Member

I did, and it needs to be done, but it would involve adding arcade publishing to a repo that doesn't even know about arcade.

@alexperovich
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mmitche mmitche merged commit c336c96 into main Apr 22, 2021
@mmitche mmitche deleted the mmitche-patch-1 branch April 22, 2021 15:38
@ViktorHofer
Copy link
Member

I don't see the SDK change flowing into the repositories, i.e.: dotnet/runtime@9c39208. Is that intentional?

@mmitche
Copy link
Member Author

mmitche commented Apr 27, 2021

Blocked up here: https://github.com/dotnet/arcade-validation/pull/2268/checks?check_run_id=2449219260

@ViktorHofer
Copy link
Member

Did you know about the pipeline being blocked? If not, would it make sense to monitor that repo via automation to notify in case something is blocked?

@mmitche
Copy link
Member Author

mmitche commented Apr 27, 2021

I think it is monitored, just no one has gotten around to investigating the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants