Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attachments because we overflowed Azure DevOps #7322

Merged
1 commit merged into from
Apr 30, 2021

Conversation

ChadNedzlek
Copy link
Member

Related to #7319

@ghost
Copy link

ghost commented Apr 29, 2021

Hello @ChadNedzlek!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes, a condition that will be fulfilled in about 8 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@missymessa
Copy link
Member

Since this is something that has the potential to break folks, could we make sure to communicate this change to Arcade users?

@ChadNedzlek
Copy link
Member Author

I'll rely to the mail to partners Matt sent.

@ghost
Copy link

ghost commented Apr 29, 2021

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost ghost merged commit 8d5c0ee into dotnet:main Apr 30, 2021
@MattGal
Copy link
Member

MattGal commented May 3, 2021

@ChadNedzlek do you think we should port this to the release branches? I'm not sure how much it matters since the volume is drastically lower there, but the port is cheap.

@ChadNedzlek
Copy link
Member Author

I'd be fine with not. Their volume is pretty low, and the problem seems to have been mitigated for now.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge PR once CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants