Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for LF line endings to OneLocBuild task #7334

Merged
merged 1 commit into from
May 3, 2021

Conversation

jonfortescue
Copy link
Contributor

OneLocBuild recently added the option to use LF line endings when checking in files. This is good bc most repos will want to use this, I believe. Nice!

To double check:

@jonfortescue jonfortescue self-assigned this May 3, 2021
Copy link
Member

@riarenas riarenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about making true the default.

@jonfortescue
Copy link
Contributor Author

@riarenas CRLF seems to be wrong for most repos; that's what it is currently and it results in horrid whitespace changes and requires manual normalization to fix across all the repos I've worked with so far.

@riarenas
Copy link
Member

riarenas commented May 3, 2021

That makes sense, and it makes it sound like like we really need this, and it's more of a real fix than a nice to have.

@riarenas
Copy link
Member

riarenas commented May 3, 2021

CRLF seems to be wrong for most repos

Do you know of any repos where it's not wrong? If so we should have those on radar so that they don't get surprised by the new default.

@jonfortescue
Copy link
Contributor Author

@riarenas nope, there haven't been any so far lol.

@jonfortescue jonfortescue merged commit 4bf515f into dotnet:main May 3, 2021
@jonfortescue jonfortescue deleted the AddLfLineEndingsOneLocBuild branch May 3, 2021 20:07
@ChadNedzlek
Copy link
Member

Why can't we just use the .gitattributes in the repo to do the right thing? Why make this data duplicated there?

@jonfortescue
Copy link
Contributor Author

@ChadNedzlek The OneLocBuild task is not able to do that, unfortunately

@ChadNedzlek
Copy link
Member

ChadNedzlek commented May 3, 2021

It's a little weird that it's somehow bypassing that behavior already. shrugs I guess thems the breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants