-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upped timeout and added logs for downloading and publishing operation #7351
Conversation
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use Stopwatch instead of DateTime subtraction for our timing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any example builds? Just to see how readable the logs are with these changes
Running a build now https://dnceng.visualstudio.com/internal/_build/results?buildId=1126019&view=results, I will post the log here after this completes |
I think it would be nice to not lose the decimals in the seconds. |
Yeah all the downloads were 0 seconds :D , made sure we have decimals for time taken |
To double check: