Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the package testing for runtime packages using the dotnet pack task #7360

Merged
merged 1 commit into from
May 8, 2021
Merged

Fixes the package testing for runtime packages using the dotnet pack task #7360

merged 1 commit into from
May 8, 2021

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented May 7, 2021

we no longer manually set the title in the dotnet pack task, hence we will have to replace title with id.

@ericstj
Copy link
Member

ericstj commented May 7, 2021

we no longer manually set the title in the dotnet pack task

The task does honor it, we just aren't setting the property it expects, which is fine: ID is more appropriate.
https://github.com/NuGet/NuGet.Client/blob/16f764f537a5d3d96d4748b52958ac287eae6deb/src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.targets#L226

@ericstj ericstj mentioned this pull request May 7, 2021
Merged
@Anipik Anipik merged commit 5faea1b into dotnet:main May 8, 2021
@Anipik Anipik deleted the packageId branch May 11, 2021 19:23
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericstj ericstj ericstj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anipik @ericstj