Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hosted pools for PR builds #7384

Merged
merged 1 commit into from
May 12, 2021
Merged

Conversation

ChadNedzlek
Copy link
Member

Public builds spend almost 30 minutes waiting for BuildPool machines to then do 2 minutes of building,
let's use the hosted pools

Copy link
Member

@missymessa missymessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM shipit

Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we keep doing this, we should perhaps remove the arcade buildpools from existence. There are so many things using the production providers now we don't need the test coverage at all.

Ironically, before runtime's build got too big, we needed this because hosted got backed up... :)

@ChadNedzlek
Copy link
Member Author

I feel like random arcade PR's aren't the right way to test the pool provider anyway. :-)

@MattGal
Copy link
Member

MattGal commented May 12, 2021

I feel like random arcade PR's aren't the right way to test the pool provider anyway. :-)

No I meant as something we're always depending on so we notice maybe before the users. Users tend to beat us anyway.

@ChadNedzlek
Copy link
Member Author

My next PR is going to be to delete the bin directory after the build task. I really want this build to be fast enough that it's I don't have to go forget all about it and leave dangling PR's all over the place. :-)

@ChadNedzlek ChadNedzlek merged commit bf714ea into dotnet:main May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants