Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize Uris when writing manifests #7521

Merged
merged 5 commits into from
Jun 15, 2021

Conversation

michellemcdaniel
Copy link
Contributor

@michellemcdaniel michellemcdaniel commented Jun 14, 2021

For each manifest, we should normalize the Azure DevOps uris, so that differences between machine state do not affect merging the manifests down the line. We will normalize the AzureDevOpsRepository and the InitialAssetsLocations, if found in the attributes.

Fixes #7493.

To double check:

For each manifest, we should normalize the Azure DevOps uris, so that differences between machine state do not affect merging the manifests down the line. We will normalize the AzureDevOpsRepository and the InitialAssetsLocations, if found in the attributes.
@riarenas riarenas requested review from mmitche and epananth June 14, 2021 20:46
@riarenas
Copy link
Member

Can we add tests for this to https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Build.Tasks.Feed.Tests/BuildModelFactoryTests.cs?

@michellemcdaniel
Copy link
Contributor Author

I wasn't sure exactly how to fit it in, but I will try.

@michellemcdaniel
Copy link
Contributor Author

Updated the tests with the new normalization info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize Azure devops URIs during asset manifest creation
3 participants