Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate feedback on OneLocBuild doc #7522

Merged
merged 6 commits into from
Jun 15, 2021

Conversation

jonfortescue
Copy link
Contributor

@jonfortescue jonfortescue commented Jun 14, 2021

Got some feedback from MSBuild folks on the doc so incorporating that here.

To double check:

Sorry, something went wrong.

@jonfortescue jonfortescue self-assigned this Jun 14, 2021
Copy link
Member

@benvillalobos benvillalobos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The clarification helps a lot! Small suggestion for clarity, but good as is IMO

Documentation/OneLocBuild.md Outdated Show resolved Hide resolved
Co-authored-by: Ben Villalobos <4691428+BenVillalobos@users.noreply.github.com>
@jonfortescue jonfortescue merged commit 52476e9 into dotnet:main Jun 15, 2021
@jonfortescue jonfortescue deleted the FeedbackOnOneLocBuildDoc branch June 15, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants