Recognize files in ref-pack under "analyzers" as analyzers and write them to the frameworkList #7561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…them to the frameworkList
4 tasks
jkoritzinsky
approved these changes
Jun 24, 2021
|
I'd like to wait to merge this until I have a chance to test out the consumption side in dotnet/runtime, and my changes to SDK, |
Platform manifest creation uses a dictionary to map template items to files in the package, but didn't account for duplicate file names (as is the case with .resources.dll). Handle this by taking the first file of a particular name. Include `analyzer/` prefixed files in framework list. Allow for analyzers to be excluded from closure and type validation with ExcludeFromValidation metadata. This metadata is necessary because analyzers will be missing dependencies provided by the compiler, and their resource.dll will have duplicate files, both which would result in errors.
|
Yep, needed a couple additional fixes. This is ready to go now. Here's what consumption looks like: |
ViktorHofer
approved these changes
Jun 29, 2021
|
Hello @ericstj! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
1 task
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://github.com/dotnet/designs/blob/main/accepted/2021/InboxSourceGenerators.md
SDK consumption: dotnet/sdk#18501