Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes null reference when there are no packs in a workload definition #7568

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Fixes null reference when there are no packs in a workload definition #7568

merged 1 commit into from
Jun 30, 2021

Conversation

joeloff
Copy link
Member

@joeloff joeloff commented Jun 29, 2021

  • Fixing null reference for workloads that only extend other workloads without specifying direct pack dependencies.
  • Fixes directory references for workload pack generation. This was a regression from a change to support manifest MSI

@joeloff joeloff requested review from chcosta, wli3 and sfoslund June 29, 2021 06:51
@joeloff
Copy link
Member Author

joeloff commented Jun 29, 2021

@pjcollins as an FYI

@joeloff joeloff requested a review from bekir-ozturk June 30, 2021 15:55
@joeloff joeloff merged commit 812a324 into dotnet:main Jun 30, 2021
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bekir-ozturk bekir-ozturk bekir-ozturk approved these changes

@chcosta chcosta Awaiting requested review from chcosta

@wli3 wli3 Awaiting requested review from wli3

@sfoslund sfoslund Awaiting requested review from sfoslund

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeloff @bekir-ozturk