Add internal runtime args to source build template #7659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These need to be passed through to correct restore an internal runtime. This is a follow-on to a previous attempt (dotnet#7587). The two changes from that are: - Use the eng/common/build.sh variation of runtimesourcefeed/runtimesourcefeedkey (without -'s) - Determine whether the MSRC variable is actually set before adding the args.
|
@riarenas Attempt 2. /cc @lukas-lansky |
riarenas
approved these changes
Jul 22, 2021
|
FYI: Tested on an arcade official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1253461&view=logs&j=2f0d093c-1064-5c86-fc5b-b7b1eca8e66a |
|
Build with the variable group available: https://dev.azure.com/dnceng/internal/_build/results?buildId=1253519&view=logs&j=2f0d093c-1064-5c86-fc5b-b7b1eca8e66a&t=d2b639a6-cb19-5f1f-66fd-8047f66b3026 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These need to be passed through to correct restore an internal runtime.
This is a follow-on to a previous attempt (#7587). The two changes from that are:
To double check: