Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Validation documentation #7669

Merged
merged 6 commits into from
Jul 29, 2021
Merged

Add Validation documentation #7669

merged 6 commits into from
Jul 29, 2021

Conversation

michellemcdaniel
Copy link
Contributor

To double check:

jonfortescue
jonfortescue reviewed Jul 26, 2021
View reviewed changes
Copy link
Contributor

@jonfortescue jonfortescue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prose changes are all nits/optional suggestions!

Documentation/Validation.md Outdated Show resolved Hide resolved
Documentation/Validation.md Outdated Show resolved Hide resolved
Documentation/Validation.md Outdated Show resolved Hide resolved
Documentation/Validation.md Outdated Show resolved Hide resolved
Documentation/Validation.md Outdated Show resolved Hide resolved
Documentation/Validation.md Outdated Show resolved Hide resolved
Documentation/Validation.md Outdated Show resolved Hide resolved
Documentation/Validation.md Outdated Show resolved Hide resolved
Documentation/Validation.md Outdated Show resolved Hide resolved
Documentation/Validation.md Outdated Show resolved Hide resolved
markwilkie
markwilkie approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@markwilkie markwilkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

Documentation/Validation.md Show resolved Hide resolved
Documentation/Validation.md Show resolved Hide resolved
Documentation/Validation.md Show resolved Hide resolved
@michellemcdaniel michellemcdaniel mentioned this pull request Jul 27, 2021
Closed
@michellemcdaniel michellemcdaniel merged commit ce7357e into dotnet:main Jul 29, 2021
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonfortescue jonfortescue jonfortescue approved these changes

@markwilkie markwilkie markwilkie approved these changes

@epananth epananth Awaiting requested review from epananth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michellemcdaniel @markwilkie @jonfortescue