Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup internal runtime support for source build #7711

Merged
merged 2 commits into from
Aug 5, 2021

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Aug 4, 2021

  • Add internal runtime download arguments as msbuild parameters, replacing the script parameters
  • Add internal nuget feed support
  • Modify the source build command to save the WIP changes in the test repo, which will cover changes to the NuGet.config file
  • Set up the user name and email if not set to support WIP changes.

To double check:

- Add internal runtime download arguments as msbuild parameters, replacing the script parameters
- Add internal nuget feed support
- Modify the source build command to save the WIP changes in the test repo, which will cover changes to the NuGet.config file
- Set up the user name and email if not set to support WIP changes.
@mmitche mmitche requested a review from MichaelSimons August 4, 2021 18:28
@mmitche
Copy link
Member Author

mmitche commented Aug 4, 2021

This is necessary for aspnetcore to succeed (due to the way it does its initial tasks build)
@mmitche
Copy link
Member Author

mmitche commented Aug 5, 2021

This is g2g

@mmitche mmitche merged commit a14c239 into dotnet:main Aug 5, 2021
@mmitche mmitche deleted the fix-source-build-template branch February 9, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants