Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Should not publish the files in SymbolPublishingExclusionFile… #7730

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

lewing
Copy link
Member

@lewing lewing commented Aug 9, 2021

Reverts #7433 because it is breaking the runtime official build and blocking package promotion and code flow.

If the test correctly failing lets resolve the issue in the packages.

@mmitche
Copy link
Member

mmitche commented Aug 9, 2021

It would be odd that an exclusion would cause this problem. Is this an educated guess at this point?

@lewing
Copy link
Member Author

lewing commented Aug 9, 2021

#7722 mentions the failing files by name in a documentation update and the build started failing after this landed so I'm feeling fairly confident.

@lewing
Copy link
Member Author

lewing commented Aug 9, 2021

cc @epananth @riarenas

@mmitche mmitche enabled auto-merge (squash) August 9, 2021 17:11
@epananth
Copy link
Member

epananth commented Aug 9, 2021

I will investigate this further.

@lewing
Copy link
Member Author

lewing commented Aug 9, 2021

@premun there was a failure in the xharness tests on ios here
https://dev.azure.com/dnceng/public/_build/results?buildId=1283631&view=logs&j=50e98f4f-3b28-577a-6481-eda1b1f9a1d6&t=0d8ba9c6-80f7-5028-ba65-cd1bbb3d6e35&s=ee3800fd-6e81-525f-e564-94108585217d

[13:36:44] dbug: Xamarin.Hosting: Booted iPhone X (iOS 13.5) - created by XHarness successfully.
[13:36:44] dbug: Xamarin.Hosting: Launching net.dot.System.Numerics.Vectors.Tests async on 'iOS 13.5 (17F61) - iPhone X' with: {
[13:36:44] dbug: arguments =     (
[13:36:44] dbug: );
[13:36:44] dbug: environment =     {
[13:36:44] dbug: NSUnbufferedIO = YES;
[13:36:44] dbug: "NUNIT_AUTOEXIT" = true;
[13:36:44] dbug: "NUNIT_ENABLE_XML_OUTPUT" = true;
[13:36:44] dbug: "NUNIT_HOSTNAME" = "127.0.0.1";
[13:36:44] dbug: "NUNIT_HOSTPORT" = 56366;
[13:36:44] dbug: "NUNIT_XML_VERSION" = xUnit;
[13:36:44] dbug: "OS_ACTIVITY_DT_MODE" = YES;
[13:36:44] dbug: };
[13:36:44] dbug: stderr = "/tmp/helix/working/B1230989/w/AB490967/uploads/net.dot.System.Numerics.Vectors.Tests.log";
[13:36:44] dbug: stdout = "/tmp/helix/working/B1230989/w/AB490967/uploads/net.dot.System.Numerics.Vectors.Tests.log";
[13:36:44] dbug: }
[13:36:45] dbug: Xamarin.Hosting: Device 'iOS 13.5 (17F61) - iPhone X' booted.
['System.Numerics.Vectors.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]

Not sure if it is a known issue

@mmitche mmitche merged commit 0090a8d into main Aug 9, 2021
@lewing lewing deleted the revert-7433-excludeSymbols branch August 9, 2021 18:53
@epananth
Copy link
Member

epananth commented Aug 9, 2021

The reason this fixed failed is cos arcade needed an arcade update. So only the post build thing happened and the first part where we upload the file to the container did not happen. So I am going to recreate this PR and I am running another test in runtime to prove this.

@premun
Copy link
Member

premun commented Aug 17, 2021

Looks like the app installation took a very long time (but succeeded) and then Helix killed the job because of a timeout:

[13:21:53] dbug: Xamarin.Hosting: Installing /tmp/helix/working/B1230989/w/AB490967/e/System.Numerics.Vectors.Tests.app with Bundle Identifier net.dot.System.Numerics.Vectors.Tests on 'iOS 13.5 (17F61) - iPhone X'...
[13:35:17] dbug: Xamarin.Hosting: Installed 'net.dot.System.Numerics.Vectors.Tests' from /tmp/helix/working/B1230989/w/AB490967/e/System.Numerics.Vectors.Tests.app

I opened dotnet/xharness#690 to track this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants