Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to add symbol exclusion feature #7737

Merged
2 commits merged into from
Aug 11, 2021

Conversation

epananth
Copy link
Member

To double check:

Arcade update to add symbol exclusion feature

@epananth epananth requested a review from riarenas August 10, 2021 23:40
@riarenas
Copy link
Member

Actually, since you're here, and @garath is probably going to do the exact same PR, could we update to this build instead? https://dev.azure.com/dnceng/internal/_build/results?buildId=1286750&view=results

@epananth
Copy link
Member Author

Yes will do

@epananth
Copy link
Member Author

Updated with @garath's changes

@epananth epananth requested a review from garath August 10, 2021 23:48
@epananth epananth added the auto-merge Automatically merge PR once CI passes. label Aug 10, 2021
@ghost
Copy link

ghost commented Aug 10, 2021

Hello @epananth!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes, a condition that will be fulfilled in about 3 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@garath
Copy link
Member

garath commented Aug 11, 2021

This will be okay even though the change I made isn't through validation? It's using the task from source?

@epananth
Copy link
Member Author

I discussed this with @riarenas, normally what happens is after we merge a PR then it gets publishing to .NetEng Validation, then cos of dependency update it creates a PR in arcade-validation where we test against product repos, once that succeeds then the change gets published to .NetEng latest.

But in this particular scenario, runtime is failing to publish, so the change cannot go to .NetEng latest. So this change will get the promotions back to green. So your task versions should be also updated in this PR. So we should be good.

@ghost ghost merged commit e10772e into dotnet:main Aug 11, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge PR once CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants