Refactor source-index to use its own .net core #7763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
reviewed
Aug 18, 2021
ViktorHofer
reviewed
Aug 18, 2021
ViktorHofer
approved these changes
Aug 18, 2021
riarenas
approved these changes
Aug 18, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7747
Validated with https://dev.azure.com/dnceng/internal/_build/results?buildId=1301548&view=logs&j=316d5c15-0c50-544e-8051-e6b14a1ab674&t=78db2542-c627-4140-8a7a-d06178fff4e4
This change modifies the source-index stage to use its own restored sdk (3.1) instead of the one from the repo and then uses explicit paths to the tools instead of modifying the environment path . The sdk is only used to acquire the global tools and run them, but the process was being intermingled with the sdk which arcade restores from the repo.
Side note: @ViktorHofer, after this change makes it to runtime, I'm pretty sure you can get rid of https://github.com/dotnet/runtime/blob/main/eng/pipelines/source-index.yml#L10 which is a bit of a hack. You can probably get rid of that yml file entirely and just reference source-index-stage1.yml, but either way is fine.