Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating Microbuild task #7800

Merged
merged 1 commit into from
Aug 26, 2021
Merged

updating Microbuild task #7800

merged 1 commit into from
Aug 26, 2021

Conversation

missymessa
Copy link
Member

To double check:

Updated per the instructions here: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_wiki/wikis/DevDiv.wiki/23804/Known-Errors

@missymessa missymessa requested review from MattGal and chcosta August 26, 2021 21:32
@MattGal
Copy link
Member

MattGal commented Aug 26, 2021

Please also do release branches

@riarenas
Copy link
Member

riarenas commented Aug 26, 2021

Maybe also update https://github.com/dotnet/arcade/blob/main/Documentation/ArcadeSdk.md#signing-plugin-installation? Looks to be remarkably outdated, still using @1 with a weird task name.

@missymessa missymessa added the auto-merge Automatically merge PR once CI passes. label Aug 26, 2021
@ghost
Copy link

ghost commented Aug 26, 2021

Hello @missymessa!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Aug 26, 2021

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. DotNet Maestro - Int
  2. Codecov
  3. DotNet Maestro
  4. Dependabot

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

1 similar comment
@ghost
Copy link

ghost commented Aug 26, 2021

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. DotNet Maestro - Int
  2. Codecov
  3. DotNet Maestro
  4. Dependabot

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@missymessa
Copy link
Member Author

Maybe also update https://github.com/dotnet/arcade/blob/main/Documentation/ArcadeSdk.md#signing-plugin-installation? Looks to be remarkably outdated, still using @1 with a weird task name.

I'll take care of this tomorrow in another PR :)

@missymessa missymessa merged commit d3faddd into main Aug 26, 2021
@missymessa missymessa deleted the missymessa-7799 branch August 26, 2021 23:43
@missymessa missymessa restored the missymessa-7799 branch August 27, 2021 16:19
@riarenas riarenas mentioned this pull request Aug 27, 2021
1 task
@missymessa missymessa deleted the missymessa-7799 branch August 27, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge PR once CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants