Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ProductVersion.txt where possible (port PR #7837 to rel/6.0) #7861

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Use ProductVersion.txt where possible (port PR #7837 to rel/6.0) #7861

merged 1 commit into from
Sep 9, 2021

Conversation

MattGal
Copy link
Member

@MattGal MattGal commented Sep 9, 2021

  • Add ProductVersion.txt support where possible; get the version of the inner package from productVersion.txt, NOT from the specified version. Allows "non-stable" outer container with "stable" inner contents

#7836

To double check:

@MattGal
Use ProductVersion.txt where possible (dotnet#7837)
caccdca 
* Add ProductVersion.txt support where possible; get the version of the inner package from productVersion.txt, NOT from the specified version.  Allows "non-stable" outer container with "stable" inner contents

dotnet#7836
@MattGal MattGal mentioned this pull request Sep 9, 2021
Closed
2 tasks
dougbu
dougbu approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM as long as we don't need some type of additional approval for this branch

@MattGal MattGal merged commit d17fe1b into dotnet:release/6.0 Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattGal @dougbu