Revert changes breaking build on FreeBSD #7885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps .NET build on FreeBSD.
Current release is 12, not 11.
These changes have previously been introduced in `dotnet/runtime`, but been reverted through automated updates later on. This commit re-introduces them.
|
LGTM! Thanks for getting this in! |
|
I’ll create another PR for runtime directly too, just so we won’t have to wait for another package update to restore FreeBSD buildability 🙂 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts changes introduced in dotnet/runtime#58314 which breaks the .NET build on FreeBSD, and does so in a way to try to avoid regressions being reintroduced later on when new packages are updated.
CC: @jkotas @Thefrank