Update mac x64 installer script arch detection #7913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericstj
reviewed
Sep 17, 2021
src/Microsoft.DotNet.Build.Tasks.Installers/src/GenerateMacOSDistributionFile.cs
Outdated
Show resolved
Hide resolved
sfoslund
force-pushed
the
sfoslund/MacOSx64Script
branch
from
aea769f to
e8951bf
Compare
ericstj
reviewed
Sep 17, 2021
src/Microsoft.DotNet.Build.Tasks.Installers/src/GenerateMacOSDistributionFile.cs
Show resolved
Hide resolved
ericstj
approved these changes
Sep 17, 2021
ericstj
pushed a commit
to ericstj/arcade
that referenced
this pull request
Sep 17, 2021
* Update mac x64 installer script arch detection * Add comments to x64 machine detection script
am11
reviewed
Sep 18, 2021
| var result = machine == ""x64"" || machine.endsWith(""_x64""); | ||
| system.log(""IsX64Machine: "" + result); | ||
| return result; | ||
| var machine = system.sysctl(""hw.foo""); |
There was a problem hiding this comment.
is .foo a typo or is it to imply that hw .anything returns machine architecture?
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validated manually using both a x64 and arm64 machine