Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in mac installer generation script #7917

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Conversation

sfoslund
Copy link
Member

No description provided.

@sfoslund sfoslund requested a review from ericstj September 20, 2021 16:12
@@ -42,7 +42,7 @@ public override bool Execute()

var archScriptContent = @"<![CDATA[
function IsX64Machine() {
var machine = system.sysctl(""hw.foo"");
var machine = system.sysctl(""hw.machine"");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we have proof our fallback code works if mac were to ever stop reporting this sysctl.

@ericstj ericstj merged commit f959b45 into main Sep 20, 2021
@sfoslund sfoslund deleted the sfoslund/MacScriptFix branch September 20, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants