Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https://github.com/dotnet/core-eng/issues/13691 - refactor variable setting so we can also do it in MSBuild-Core() #7921

Merged
merged 1 commit into from
Sep 22, 2021
Merged

https://github.com/dotnet/core-eng/issues/13691 - refactor variable setting so we can also do it in MSBuild-Core() #7921

merged 1 commit into from
Sep 22, 2021

Conversation

jakubstilec
Copy link
Contributor

dotnet/core-eng#13691 merge to release/6.0

To double check:

@jakubstilec jakubstilec requested a review from MattGal September 21, 2021 12:42
MattGal
MattGal approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, runtime's no longer blocked as they set the variables globally in their release branch as well now too.

@jakubstilec jakubstilec merged commit 1ee936e into dotnet:release/6.0 Sep 22, 2021
@jakubstilec jakubstilec mentioned this pull request Sep 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattGal MattGal MattGal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubstilec @MattGal