-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uninstall apps after timeout or installation failure #7970
Uninstall apps after timeout or installation failure #7970
Conversation
@greenEkatherine I think we rather need your PowerShell loop that uninstalls everything (people can install more than 1 apk during the CustomCommands) For the ADB part, Bill Wert was already asking for this feature to get the path to the exe so we might as well do that now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work well. One more thing to consider is whether we shouldn't do this for other cases than time out (e.g. PACKAGE_INSTALLATION_FAILURE
often means the storage is full and this would help)
src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner/xharness-helix-job.android.ps1
Outdated
Show resolved
Hide resolved
…helix-job.android.ps1 Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
Agree, but should I add it here or in separate PR? |
I would add it here since it's the same piece of code just in a different place? |
To double check: