Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall apps after timeout or installation failure #7970

Merged
merged 8 commits into from
Oct 21, 2021

Conversation

greenEkatherine
Copy link
Contributor

To double check:

@premun
Copy link
Member

premun commented Sep 29, 2021

@greenEkatherine I think we rather need your PowerShell loop that uninstalls everything (people can install more than 1 apk during the CustomCommands)
dotnet/xharness#663 (comment)

For the ADB part, Bill Wert was already asking for this feature to get the path to the exe so we might as well do that now

@greenEkatherine greenEkatherine marked this pull request as ready for review October 19, 2021 14:57
Copy link
Member

@premun premun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work well. One more thing to consider is whether we shouldn't do this for other cases than time out (e.g. PACKAGE_INSTALLATION_FAILURE often means the storage is full and this would help)

…helix-job.android.ps1

Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
@greenEkatherine
Copy link
Contributor Author

This should work well. One more thing to consider is whether we shouldn't do this for other cases than time out (e.g. PACKAGE_INSTALLATION_FAILURE often means the storage is full and this would help)

Agree, but should I add it here or in separate PR?

@premun
Copy link
Member

premun commented Oct 19, 2021

I would add it here since it's the same piece of code just in a different place?

@greenEkatherine greenEkatherine changed the title Uninstall app after timeout Uninstall app after timeout or installation failure Oct 19, 2021
@greenEkatherine greenEkatherine changed the title Uninstall app after timeout or installation failure Uninstall apps after timeout or installation failure Oct 19, 2021
@greenEkatherine greenEkatherine enabled auto-merge (squash) October 21, 2021 11:19
@greenEkatherine greenEkatherine merged commit 997a1e6 into dotnet:main Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants