Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back SymbolTargetType to feed configs #8024

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Add back SymbolTargetType to feed configs #8024

merged 2 commits into from
Oct 12, 2021

Conversation

alexperovich
Copy link
Member

To double check:

@alexperovich alexperovich self-assigned this Oct 12, 2021
@alexperovich alexperovich mentioned this pull request Oct 12, 2021
Closed
2 tasks
riarenas
riarenas approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@riarenas riarenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we can guard against in the SetupTargetFeedConfigV3Tests?

https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Build.Tasks.Feed.Tests/SetupTargetFeedConfigV3Tests.cs

@alexperovich
Copy link
Member Author

Possibly, if it wasn't set to None in the tests. I will try it.

@alexperovich alexperovich enabled auto-merge (squash) October 12, 2021 19:14
@alexperovich alexperovich merged commit c451265 into dotnet:main Oct 12, 2021
@alexperovich alexperovich deleted the putBackSymbolTargetType branch October 12, 2021 21:08
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epananth epananth epananth approved these changes

@riarenas riarenas riarenas approved these changes

@michellemcdaniel michellemcdaniel michellemcdaniel approved these changes

Assignees

@alexperovich alexperovich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexperovich @michellemcdaniel @riarenas @epananth