Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.Net.Sdk.WorkloadManifestReader to RTM version #8054

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

MattGal
Copy link
Member

@MattGal MattGal commented Oct 18, 2021

#7880 - there were a couple small breaking changes that required minor updates. This change passes all tests but it is possible further breaking changes may be found later.

To double check:

@MattGal MattGal requested a review from joeloff October 18, 2021 18:37
Copy link
Member

@riarenas riarenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what any of these versions are or what this component is used for. The update seems fine though.

@MattGal
Copy link
Member Author

MattGal commented Oct 18, 2021

I've verified via debugging w/ the tests that the changes give the results I'd expect; there is some expectation that this may no longer be in use since we'd expect this update to have already occurred if so, but we can address that in the future if we have to.

@MattGal MattGal merged commit 7d956be into dotnet:main Oct 18, 2021
@joeloff
Copy link
Member

joeloff commented Oct 18, 2021

If there were changes in the behavior it could impact the generated workload packs/manifests for VS. There's no way to tell until you actually do a full build of the workloads, e.g. EMSDK or runtime (for the mono workloads), but this should be okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants