Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SymUploader to incoporate additional params for symbol publishing #8111

Merged
merged 4 commits into from
Oct 28, 2021

Conversation

epananth
Copy link
Member

To double check:

Part 2 changes for issue -> #7988

This change includes additional param TreatPdbConversionIssuesAsInfo, so that we do not error out during the scenario where the symbols do not contain any .dlls during pdb conversion

For V3 this param is always going to be false since we do not do the pdb conversion for every build. Staging pipeline still uses V2 so we made this param settable in PublishSymbol.proj

@epananth epananth requested review from mmitche and hoyosjs October 27, 2021 15:28
Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a run of any big repo on top of this? Say runtime or ASP?

@epananth
Copy link
Member Author

I noticed that, for non streaming (uploading to symbol server) we get the SymbolExclusion file but dont actually use it. So I added that check too.

I will post the test soon.

@epananth
Copy link
Member Author

@epananth
Copy link
Member Author

@epananth
Copy link
Member Author

Reverted the older publishing change, that might break some validation stuff. We do not need this for now. I will create another issue to address that..

@epananth epananth merged commit 5478664 into dotnet:main Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants