Use XHarness' diagnostics output to detect infrastructure issues #8139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattGal
approved these changes
Nov 5, 2021
|
Yeah! Piece by piece, edge case by edge case. I think this change will bring a lot of good things for maintenance |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on the work item to request retry/reboot, we do it in the SDK at the end of the job while reading the
diagnostics.jsonfile generated by XHarness.This will transparently work for any number of XHarness commands executed during the work item and can be a single place for the logic. It also unifies the logic we had duplicated over the
.psand.shfiles.The user then doesn't need to categorize or react on failed XHarness commands in any way.
We still allow the users to request retry/reboot using the .dotfiles but it should not be necessary.
Resolves #8109