Fix InitializeDotNetCli call in darc-init.sh #8190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the ps1 script, we set install to true, but in the sh script, we weren't, so tools.sh would see that install is not set, and assume dotnet was already installed in the expected place, which isn't true. This change adds true to the InitializeDotNetCli call so that dotnet will be installed if needed when running darc-init.sh
mmitche
approved these changes
Nov 16, 2021
riarenas
approved these changes
Nov 16, 2021
|
What issue is this solving? something in the release repo? |
|
I was trying to initialize darc on my macbook, and it was failing to get dotnet |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ps1 script, we set install to true, but in the sh script, we weren't, so tools.sh would see that install is not set, and assume dotnet was already installed in the expected place, which isn't true. This change adds true to the InitializeDotNetCli call so that dotnet will be installed if needed when running darc-init.sh
To double check: