Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable NuGetAuthenticate on internal PRs #8209

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Enable NuGetAuthenticate on internal PRs #8209

merged 3 commits into from
Nov 23, 2021

Conversation

garath
Copy link
Member

@garath garath commented Nov 22, 2021

Enable NuGetAuthenticate on internal PRs.

Resolves #7663.

hoyosjs
hoyosjs approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, this lgtm. This leaves us in a better place anyway.

eng/common/templates/job/job.yml Outdated Show resolved Hide resolved
@mmitche @hoyosjs
Update eng/common/templates/job/job.yml
81cb2bf 
Co-authored-by: Juan Hoyos <juan.hoyos@microsoft.com>
@garath garath merged commit 927f8d4 into dotnet:main Nov 23, 2021
@garath
Copy link
Member Author

garath commented Nov 23, 2021

Thanks to everyone for your participation.

@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoyosjs hoyosjs hoyosjs approved these changes

@riarenas riarenas Awaiting requested review from riarenas

@mmitche mmitche Awaiting requested review from mmitche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NugetAuth task should run on internal PRs by default (Port to release branches)
4 participants
@garath @mmitche @hoyosjs @riarenas