Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Remove graph file generation functionality (port #8315) #8323

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Jan 6, 2022

Description

Removes the functionality from the templates that generates graph files. These aren't really useful anymore, as BARViz subsumed this functionality a long while back. We also need to move to the 1ES pools, so this removes another place where they aren't in use.

Repos that happen to still specify should not see a break, and the additional parameters (graphFileGeneration) should just get ignored.

Customer Impact

Removes another place where we can accidentally use the non-1ES pools

Regression

No

Risk

Low, won't break anything if a build is using this functionality

Workarounds

Repos could remove the graph file generation themselves.

To double check:

Removes the functionality from the templates that generates graph files. These aren't really useful anymore, as BARViz subsumed this functionality a long while back. We also need to move to the 1ES pools, so this removes another place where they aren't in use.

Repos that happen to still specify should not see a break, and the additional parameters (graphFileGeneration) should just get ignored.
@mmitche mmitche changed the title Remove graph file generation functionality (#8315) [release/6.0] Remove graph file generation functionality (port #8315) Jan 6, 2022
@mmitche mmitche requested a review from markwilkie January 6, 2022 19:51
@mmitche
Copy link
Member Author

mmitche commented Jan 7, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mmitche mmitche merged commit 5b877f2 into dotnet:release/6.0 Jan 19, 2022
@mmitche mmitche deleted the remove-graph-file-gen-6.0 branch February 9, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants