set content type and no-cache headers to blob publishing #8373
Conversation
|
I'll make sure to try a publishing job using an sdk with these changes if this is the way we want to go, have a test build here producing an sdk: https://dev.azure.com/dnceng/internal/_build/results?buildId=1565422&view=results |
src/Microsoft.DotNet.Build.Tasks.Feed/src/AzureStorageAssetPublisher.cs
Outdated
Show resolved
Hide resolved
|
I think I'll be able to verify once this publishing build completes: https://dev.azure.com/dnceng/internal/_build/results?buildId=1565830&view=logs&j=ba23343f-f710-5af9-782d-5bd26b102304. It should be using an sdk with these changes. |
|
It works! https://dotnetcli.azureedge.net/dotnet/Sdk/7.0.100-alpha.1.22071.3/win_x86_Release_version_badge.svg has the right content type set. Oh wait, this is dotnetcli hmm |
|
I took an already existing installer build and published that to general-testing, I'm going to try this with a new build |
|
Yep that was the previous problem. Since I took a build that had already published blobs, they didn't get updated. I ran this new build of installer in a test branch: https://dev.azure.com/dnceng/internal/_build/results?buildId=1565904&view=results and then published it here: https://dev.azure.com/dnceng/internal/_build/results?buildId=1566020&view=logs&j=ba23343f-f710-5af9-782d-5bd26b102304&t=c7a8693b-2f9c-5ea8-c909-cde9405ac2e1 https://dotnetbuilds.azureedge.net/public/Sdk/7.0.100-alpha.1.22071.7/linux-musl_arm64_Release_version_badge.svg loads just fine from dotnetbuilds and it has the right content type set. @alexperovich PTAL when you can. |
https://github.com/dotnet/core-eng/issues/15377
We lost the headers we used to set when moving to the new publisher for blobs, so badges are getting the wrong content type when being uploaded.
I'm reusing the logic we previously had in place for this. Let me know if you'd rather I copy these functions to some other utility class.
To double check: