Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for NS2x runtime tfms and rename package to Microsoft.DotNet.Build.Tasks.TargetFramework #8418

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Feb 1, 2022

Fixes #4859

dotnet/runtime was the only consumer that dependent on runtime specific
.NETStandard tfms. Now that we are removing them with
dotnet/runtime#64610 we can also delete the
hacks to make them work in the TargetFramework package.

Also renaming the project from
Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk to
Microsoft.DotNet.Build.Tasks.TargetFramework as doesn't need to be an
msbuild sdk anymore and consuming it as a package will reduce evaluation
time.

I recommend to not merge this PR before dotnet/runtime#64610 isn't in.

@ViktorHofer ViktorHofer requested review from ericstj and safern February 1, 2022 11:46
@ViktorHofer ViktorHofer self-assigned this Feb 1, 2022
dotnet/runtime was the only consumer that dependent on runtime specific
.NETStandard tfms. Now that we are removing them with
dotnet/runtime#64610 we can also delete the
hacks to make them work in the TargetFramework package.

Also renaming the project from
Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk to
Microsoft.DotNet.Build.Tasks.TargetFramework as doesn't need to be an
msbuild sdk anymore and consuming it as a package will reduce evaluation
time.
@ViktorHofer ViktorHofer changed the title Remove support for NS2x runtime tfms Remove support for NS2x runtime tfms and rename package to Microsoft.DotNet.Build.Tasks.TargetFramework Feb 1, 2022
@ViktorHofer
Copy link
Member Author

Logging off now. Would be great if you @ericstj or @safern could approve. Thanks :)

@ViktorHofer ViktorHofer merged commit be22d81 into main Feb 1, 2022
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch February 1, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TargetFramework.Sdk should ensure an unique TargetFramework property in inner builds
2 participants