Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XHarness python script for older Python versions #9663

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Fix XHarness python script for older Python versions #9663

merged 1 commit into from
Jun 13, 2022

Conversation

premun
Copy link
Member

@premun premun commented Jun 13, 2022

Seems like text=True was not available on Python <3.7

@premun
Copy link
Member Author

premun commented Jun 13, 2022

The fix works as can be seen here: https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-arcade-refs-pull-9663-merge-ded1e5b3a86843bdab/System.Buffers.Tests-x86/1/console.18988b9b.log?helixlogtype=result

Reporting 1 events from diagnostics file `/datadisks/disk1/work/BE3509F8/w/BAB609FD/e/diagnostics.json`
Analyzing android/test@x86_64 (0)
2022-06-13T15:31:06.635Z	INFO   	xharness-event-processor.py	event(51)	send	Sending event type _MobileDeviceOperation
2022-06-13T15:31:06.772Z	INFO   	xharness-event-processor.py	saferequests(87)	request_with_retry	Response complete with status code '201'

@premun premun enabled auto-merge (squash) June 13, 2022 15:37
@premun premun merged commit ff30132 into dotnet:main Jun 13, 2022
@premun premun deleted the prvysoky/fix-python-ubuntu branch June 13, 2022 16:07
@premun premun changed the title Fix XHarness python script for older Fix XHarness python script for older Python versions Jun 16, 2022
@fanyang-mono fanyang-mono mentioned this pull request Jun 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkurepa dkurepa dkurepa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@premun @dkurepa