Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Npgsql component doesn't allow configuration of the NpgsqlDbContextOptionsBuilder #438

Closed
davidfowl opened this issue Oct 22, 2023 · 0 comments · Fixed by #630
Closed

Npgsql component doesn't allow configuration of the NpgsqlDbContextOptionsBuilder #438

davidfowl opened this issue Oct 22, 2023 · 0 comments · Fixed by #630
Assignees
@eerhardt
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Milestone
preview-1 week

Comments

@davidfowl
Copy link
Member

davidfowl commented Oct 22, 2023 •
edited
Loading

I'm trying to turn on pgvector support using the aspire component and it seems like we don't have an easy overload to allow passing through a lambda that provides access to the NpgsqlDbContextOptionsBuilder before the DbContextOptions are built.

We should do the same for all of the other EF providers.
@davidfowl davidfowl added the area-integrations Issues pertaining to Aspire Integrations packages label Oct 22, 2023
@eerhardt eerhardt added this to the preview-1 week milestone Oct 23, 2023
eerhardt added a commit that referenced this issue Nov 1, 2023
@eerhardt
Allow for configuring DbContextOptions in EF Components
da24791 
Fix #438
@eerhardt eerhardt mentioned this issue Nov 1, 2023
Merged
@eerhardt eerhardt self-assigned this Nov 1, 2023
@eerhardt eerhardt mentioned this issue Nov 1, 2023
Merged
eerhardt added a commit that referenced this issue Nov 1, 2023
@eerhardt
Fix database issues (#630)
a617a54 
* Allow for configuring DbContextOptions in EF Components

Fix #438

* Enable Npgsql Meter instead of using EventCounters

Need to disable the prepared_ratio instrument until #629 is fixed.

Fix #442

* Update Telemetry doc for updated Metrics
eerhardt added a commit that referenced this issue Nov 1, 2023
@eerhardt
Fix database issues (#630)
8a18a05 
* Allow for configuring DbContextOptions in EF Components

Fix #438

* Enable Npgsql Meter instead of using EventCounters

Need to disable the prepared_ratio instrument until #629 is fixed.

Fix #442

* Update Telemetry doc for updated Metrics
@eerhardt eerhardt mentioned this issue Nov 1, 2023
Merged
joperezr pushed a commit that referenced this issue Nov 1, 2023
@eerhardt
Fix database issues (#630) (#637)
f990b7b 
* Allow for configuring DbContextOptions in EF Components

Fix #438

* Enable Npgsql Meter instead of using EventCounters

Need to disable the prepared_ratio instrument until #629 is fixed.

Fix #442

* Update Telemetry doc for updated Metrics
joperezr added a commit that referenced this issue Nov 14, 2023
@joperezr
Merged PR 35020: Merge branch 'release/8.0-preview1' into internal/re…
e3b1161 
…lease/8.0-preview1

Related work items: #438, #615, #621, #629, #630, #631, #637
@eerhardt eerhardt mentioned this issue Dec 15, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eerhardt eerhardt

Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Milestone
preview-1 week
Development

Successfully merging a pull request may close this issue.

Fix database issues dotnet/aspire
2 participants
@davidfowl @eerhardt