Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Tracing for RabbitMQ Component when we move to their v7 #562

Open
eerhardt opened this issue Oct 28, 2023 · 6 comments
Open

Enable Tracing for RabbitMQ Component when we move to their v7 #562

eerhardt opened this issue Oct 28, 2023 · 6 comments
Labels
area-integrations Issues pertaining to Aspire Integrations packages blocked external Issues that represent work that's external to this repo. rabbitmq Issues related to rabbitmq integrations
Milestone

Comments

@eerhardt
Copy link
Member

Once we have a build of RabbitMQ.Client with rabbitmq/rabbitmq-dotnet-client#1261, we will need to enable and document the "RabbitMQ.Client" ActivitySource for our component.

One thing to note is that we added our own ActivitySource for the connection retries we do:

private const string ActivitySourceName = "Aspire.RabbitMQ.Client";
private static readonly ActivitySource s_activitySource = new ActivitySource(ActivitySourceName);

We should think about how to rectify the 2 activity sources in the future. One possibility is that once open-telemetry/semantic-conventions#454 is completed, we might not need our own ActivitySource for tracing the connection tries.

@eerhardt eerhardt added the area-integrations Issues pertaining to Aspire Integrations packages label Oct 28, 2023
@eerhardt eerhardt added this to the some time after preview milestone Oct 28, 2023
@danmoseley danmoseley changed the title Enable Tracing for RabbitMQ Component Enable Tracing for RabbitMQ Component when we move to their v7 Nov 12, 2023
@danmoseley danmoseley removed this from the needs milestone (for GA) milestone Nov 13, 2023
@eerhardt eerhardt added enhancement external Issues that represent work that's external to this repo. labels Jan 10, 2024
@davidfowl davidfowl added this to the preview TBD (but in 8.0) milestone Jan 27, 2024
@davidfowl
Copy link
Member

Moving into preview milestone @eerhardt

@eerhardt
Copy link
Member Author

Moving to backlog, as RabbitMQ doesn't have a stable v7 package yet. We can do this when we update for the v7 version.

@davidfowl
Copy link
Member

Is there a new package yet?

@eerhardt
Copy link
Member Author

eerhardt commented Sep 8, 2024

Is there a new package yet?

https://www.nuget.org/packages/RabbitMQ.Client/

Latest version is 7.0.0-rc.9

@mr-nuno
Copy link

mr-nuno commented Sep 13, 2024

Trying to get tracing from the Aspire.RabbitMQ.Client but without luck. Is this not supported with the 6.8.1 version of the RabbitMQ.Client or am I doing something wrong....as usual :-)

@davidfowl davidfowl added the rabbitmq Issues related to rabbitmq integrations label Sep 14, 2024
@eerhardt
Copy link
Member Author

Is this not supported with the 6.8.1 version of the RabbitMQ.Client or am I doing something wrong....as usual :-)

It is not supported in the v6.x versions of RabbitMQ.Client. It was implemented in rabbitmq/rabbitmq-dotnet-client#1261, which was merged into the v7 branch. v7 hasn't released stable yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-integrations Issues pertaining to Aspire Integrations packages blocked external Issues that represent work that's external to this repo. rabbitmq Issues related to rabbitmq integrations
Projects
None yet
Development

No branches or pull requests

5 participants