Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common socket connection conventions #454

Open
lmolkova opened this issue Oct 26, 2023 · 1 comment
Open

Common socket connection conventions #454

lmolkova opened this issue Oct 26, 2023 · 1 comment
Assignees
@jsuereth

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Oct 26, 2023 •
edited
Loading

Connection-level instrumentation is useful for all kinds of protocols to detect/investigate any connectivity issues, optimize connection pools, detect leaks, etc. The following telemetry signals are common across protocols:

  • when the connection is established/terminated/closed
    • how long it takes to attempt opening a connection
    • if a connection is terminated with an error, what was the error
  • connection duration and counters

The conventions could include:

  • spans
    • span per attempt to connect
    • span per connection
    • higher-level spans (such as HTTP) might be able to link to them
  • metrics
    • connection attempt duration
    • connection duration
    • number of active connections/connection pool size
    • number of opened connections
    • received/transmitted bytes?
    • etc

We should be able to reuse network.* and other existing common attributes to define generic connection conventions.

Individual protocols on top of sockets may extend such conventions and add protocol-specific attributes (e.g. AMQP may define some other attributes, spans/metrics).

Socket connection conventions should be reused across databases, http, messaging, and other conventions
See https://github.com/open-telemetry/semantic-conventions/blob/main/docs/database/database-metrics.md where we already define a bunch of metrics for DB connections specifically.
@lmolkova lmolkova mentioned this issue Oct 26, 2023
Merged
11 tasks
@eerhardt eerhardt mentioned this issue Oct 28, 2023
Open
jack-berg pushed a commit to jack-berg/semantic-conventions that referenced this issue Nov 7, 2023
@carlosalberto @jack-berg
Add a new AddLink() operation to Span. (#3678)
58698b4 
Fixes open-telemetry#454

Related to #3337

As the Messaging SIG merged its last OTEP 222, we will be adding operations
that require Links after Span creation, taking a direct route with `AddLink()`,
albeit without any of the new members suggested in #3337, e.g. `timestamp` (to be
discussed in a separate issue).

```
AddLink(spanContext, attributes /* optional */)
```
AlexanderWert pushed a commit to jack-berg/semantic-conventions that referenced this issue Nov 10, 2023
@carlosalberto @AlexanderWert
Add a new AddLink() operation to Span. (#3678)
a03b472 
Fixes open-telemetry#454

Related to #3337

As the Messaging SIG merged its last OTEP 222, we will be adding operations
that require Links after Span creation, taking a direct route with `AddLink()`,
albeit without any of the new members suggested in #3337, e.g. `timestamp` (to be
discussed in a separate issue).

```
AddLink(spanContext, attributes /* optional */)
```
jack-berg pushed a commit to jack-berg/semantic-conventions that referenced this issue Nov 16, 2023
@carlosalberto @jack-berg
Add a new AddLink() operation to Span. (#3678)
cbe3dcb 
Fixes open-telemetry#454

Related to #3337

As the Messaging SIG merged its last OTEP 222, we will be adding operations
that require Links after Span creation, taking a direct route with `AddLink()`,
albeit without any of the new members suggested in #3337, e.g. `timestamp` (to be
discussed in a separate issue).

```
AddLink(spanContext, attributes /* optional */)
```
jack-berg pushed a commit to jack-berg/semantic-conventions that referenced this issue Nov 16, 2023
@carlosalberto @jack-berg
Add a new AddLink() operation to Span. (#3678)
10441c5 
Fixes open-telemetry#454

Related to #3337

As the Messaging SIG merged its last OTEP 222, we will be adding operations
that require Links after Span creation, taking a direct route with `AddLink()`,
albeit without any of the new members suggested in #3337, e.g. `timestamp` (to be
discussed in a separate issue).

```
AddLink(spanContext, attributes /* optional */)
```
jsuereth pushed a commit to jack-berg/semantic-conventions that referenced this issue Nov 16, 2023
@carlosalberto @jsuereth
Add a new AddLink() operation to Span. (#3678)
68be344 
Fixes open-telemetry#454

Related to #3337

As the Messaging SIG merged its last OTEP 222, we will be adding operations
that require Links after Span creation, taking a direct route with `AddLink()`,
albeit without any of the new members suggested in #3337, e.g. `timestamp` (to be
discussed in a separate issue).

```
AddLink(spanContext, attributes /* optional */)
```
jsuereth pushed a commit to jack-berg/semantic-conventions that referenced this issue Nov 16, 2023
@carlosalberto @jsuereth
Add a new AddLink() operation to Span. (#3678)
dbcf3cc 
Fixes open-telemetry#454

Related to #3337

As the Messaging SIG merged its last OTEP 222, we will be adding operations
that require Links after Span creation, taking a direct route with `AddLink()`,
albeit without any of the new members suggested in #3337, e.g. `timestamp` (to be
discussed in a separate issue).

```
AddLink(spanContext, attributes /* optional */)
```
jsuereth pushed a commit that referenced this issue Nov 16, 2023
@carlosalberto @jsuereth
Add a new AddLink() operation to Span. (#3678)
c0513fb 
Fixes #454

Related to #3337

As the Messaging SIG merged its last OTEP 222, we will be adding operations
that require Links after Span creation, taking a direct route with `AddLink()`,
albeit without any of the new members suggested in #3337, e.g. `timestamp` (to be
discussed in a separate issue).

```
AddLink(spanContext, attributes /* optional */)
```
@trask
Copy link
Member

trask commented Nov 16, 2023

this was accidentally auto-closed (via merging an old commit that closed spec issue number 454)

@trask trask reopened this Nov 16, 2023
@lmolkova lmolkova mentioned this issue Dec 7, 2023
Open
joaopgrassi pushed a commit to dynatrace-oss-contrib/semantic-conventions that referenced this issue Jan 10, 2024
@carlosalberto
Add a new AddLink() operation to Span. (#3678)
a700d84 
Fixes open-telemetry#454 

Related to #3337 

As the Messaging SIG merged its last OTEP 222, we will be adding operations
that require Links after Span creation, taking a direct route with `AddLink()`,
albeit without any of the new members suggested in #3337, e.g. `timestamp` (to be
discussed in a separate issue).

```
AddLink(spanContext, attributes /* optional */)
```
joaopgrassi pushed a commit to dynatrace-oss-contrib/semantic-conventions that referenced this issue Jan 10, 2024
@carlosalberto
Add a new AddLink() operation to Span. (#3678)
093bd1f 
Fixes open-telemetry#454 

Related to #3337 

As the Messaging SIG merged its last OTEP 222, we will be adding operations
that require Links after Span creation, taking a direct route with `AddLink()`,
albeit without any of the new members suggested in #3337, e.g. `timestamp` (to be
discussed in a separate issue).

```
AddLink(spanContext, attributes /* optional */)
```
pyohannes pushed a commit to pyohannes/semantic-conventions that referenced this issue Jan 17, 2024
@carlosalberto @pyohannes
Add a new AddLink() operation to Span. (#3678)
c63214e 
Fixes open-telemetry#454

Related to #3337

As the Messaging SIG merged its last OTEP 222, we will be adding operations
that require Links after Span creation, taking a direct route with `AddLink()`,
albeit without any of the new members suggested in #3337, e.g. `timestamp` (to be
discussed in a separate issue).

```
AddLink(spanContext, attributes /* optional */)
```
pyohannes pushed a commit to pyohannes/semantic-conventions that referenced this issue Jan 17, 2024
@carlosalberto @pyohannes
Add a new AddLink() operation to Span. (#3678)
772673b 
Fixes open-telemetry#454

Related to #3337

As the Messaging SIG merged its last OTEP 222, we will be adding operations
that require Links after Span creation, taking a direct route with `AddLink()`,
albeit without any of the new members suggested in #3337, e.g. `timestamp` (to be
discussed in a separate issue).

```
AddLink(spanContext, attributes /* optional */)
```
@lmolkova lmolkova mentioned this issue Feb 7, 2024
Open
@github-actions github-actions bot added the Stale label Feb 11, 2024
@joaopgrassi joaopgrassi removed the Stale label Feb 14, 2024
@lmolkova lmolkova mentioned this issue Feb 17, 2024
Closed
2 tasks
@lmolkova lmolkova mentioned this issue Mar 8, 2024
Merged
3 tasks
@lmolkova lmolkova mentioned this issue Jul 9, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsuereth jsuereth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jsuereth @trask @lmolkova @joaopgrassi