-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource relationship to app model #5311
Open
JamesNK
wants to merge
4
commits into
main
Choose a base branch
from
jamesnk/resource-relationship
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchdenny
reviewed
Aug 15, 2024
src/Aspire.Hosting/ApplicationModel/ResourceRelationshipAnnotation.cs
Outdated
Show resolved
Hide resolved
mitchdenny
reviewed
Aug 15, 2024
src/Aspire.Hosting/ApplicationModel/ResourceRelationshipAnnotation.cs
Outdated
Show resolved
Hide resolved
JamesNK
force-pushed
the
jamesnk/resource-relationship
branch
from
August 19, 2024 01:47
dff7497
to
8248dae
Compare
mitchdenny
reviewed
Aug 21, 2024
From an app model perspective I am happy with where this is at except for the XML doc comments ;) |
1 task
JamesNK
force-pushed
the
jamesnk/resource-relationship
branch
from
October 9, 2024 08:18
8248dae
to
82aa476
Compare
JamesNK
force-pushed
the
jamesnk/resource-relationship
branch
from
October 29, 2024 14:36
eff7feb
to
9c67c0a
Compare
JamesNK
force-pushed
the
jamesnk/resource-relationship
branch
from
October 30, 2024 01:47
2a63a77
to
0c6bdbc
Compare
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds:
WithRelationship
extension method to app modelWithRelationship
calls are in various methods that add or reference resources.ResourceViewModel
.References
andBack references
Checklist
<remarks />
and<code />
elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow