Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FluentUI #6228

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update FluentUI #6228

wants to merge 5 commits into from

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Oct 10, 2024

Description

Update FluentUI.

Workaround for menu can't be removed as the fix in FluentUI isn't correct. Hopefully it can be removed next version. Maybe wait for the next FluentUI version as this one doesn't have changes we need.

I think we stick with the current version for 9.0.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK added area-dashboard NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels Oct 10, 2024
@JamesNK JamesNK removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 29, 2024
@JamesNK
Copy link
Member Author

JamesNK commented Oct 29, 2024

Ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant